-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: basic auth support for hydra cli #3035
Conversation
Not sure how to proceed with the 3 remaining checkboxes for such a minor change |
Codecov Report
@@ Coverage Diff @@
## master #3035 +/- ##
==========================================
- Coverage 79.52% 79.37% -0.15%
==========================================
Files 112 112
Lines 7967 7895 -72
==========================================
- Hits 6336 6267 -69
Misses 1225 1225
+ Partials 406 403 -3
Continue to review full report at Codecov.
|
This comment was marked as duplicate.
This comment was marked as duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This look great :) Could you please add documentation to the commands (for example) explaining how to use this feature? Because right now it's very hidden in the code base and noone will really know how to use it!
While the PR is being worked on I will mark it as a draft. That declutters our review backlog :) Once you're done with your changes and would like someone to review them, mark the PR as ready and request a review from one of the maintainers. Thank you! |
Hi, coming back on this (sorry, I was busy with other stuff). Sure, I'll add some doc to the command |
Required for example in case where hydra admin endpoint is protected behind a reverse proxy that enforces basic auth. If --access-token arg is set, it takes precedence over basic auth It does not apply to token revoke command
Is this ready for review? :) |
@aeneasr what kind of documentation is required to complete this? Only in Anyway, shouldn't the changes of |
Oh crap, this PR went totally out of my radar for some reason. @aeneasr I believe it's ready for review unless you see other parts that need to be documented |
Required for example in case where hydra admin endpoint
is protected behind a reverse proxy that enforces basic auth.
If
--access-token
arg is set, it takes precedence over basic authIt does not apply to the
token revoke
command which goes though the public endpoint and already uses basic auth with clientId and clientSecretRelated issue(s)
#2880
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.