Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: definitons to definitions. #784

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

dhiemaz
Copy link
Contributor

@dhiemaz dhiemaz commented Oct 29, 2021

Signed-off-by: dimas dimas.prawira@mncgroup.com

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2021

CLA assistant check
All committers have signed the CLA.

@dhiemaz dhiemaz changed the title refactor definitons to definitions. refactor: definitons to definitions. Oct 29, 2021
@aeneasr
Copy link
Member

aeneasr commented Oct 30, 2021

Thank you, this looks great! It looks like the CLA bot is not properly detecting your signature. To fix this, try the following:

$ git commit  --amend --author="Author Name <email@address.com>"

Ensure that Author Name is replaced with your GitHub username (e.g. aeneasr) and that the email address is replaced with the email address you have set up in GitHub (e.g. 3372410+aeneasr@users.noreply.github.com):

$ git commit  --amend --author="aeneasr <3372410+aeneasr@users.noreply.github.com>"

Once that is done, you can force-push your changes (make sure to push to the correct remote and branch!):

$ git push --force <remote> HEAD:<branch>

Signed-off-by: dimas <dimas.prawira@mncgroup.com>
@dhiemaz
Copy link
Contributor Author

dhiemaz commented Oct 31, 2021

hi @aeneasr thanks for the information, I have updated my PR. please check, thanks..

@aeneasr aeneasr merged commit 03e7239 into ory:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants