[WorkInProgress] Add two failing policies and equality check #106

adhicoder · 2018-02-05T11:55:35Z

No description provided.

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

…nto WorkInProgress Merging for signature change

aeneasr · 2018-02-05T12:06:36Z

manager_test_helper.go

@@ -147,6 +148,23 @@ var TestManagerPolicies = []*DefaultPolicy{
 			"owner": &EqualsSubjectCondition{},
 		},
 	},
+	//Two new policies which do not persist in MySQL correctly


So the tests might be a bit confusing here... Anything that is in TestManagerPolicies will be added automatically to the manager that is currently being tested

Alright, two questions. I changed the assert, so the assert is not failing now, but :

Why isgo test ./...not working? I am not able to test manager_test_helper.go file locally.

If the policies I added in TestManagerPolicies above are automatically added to the manager that is currently being tested, why are the tests failing now? ladon.Conditions(nil) is mentioned in the error trace, but I do not understand.

Why is go test ./... not working? I am not able to test manager_test_helper.go file locally.

I don't know, make sure to run it from the project root. Add a test that fails for sure (assert.True(false)) and see if tests fail.

If the policies I added in TestManagerPolicies above are automatically added to the manager that is currently being tested, why are the tests failing now? ladon.Conditions(nil) is mentioned in the error trace, but I do not understand.

You omitted the conditions which causes them to be of nil value but it the manager never returns conditions of type nil in order to prevent invalid pointer panics. If you look at the other policies you'll notice that each policy sets Conditions: Conditions{}, which you omitted

aeneasr · 2018-02-05T12:07:27Z

Here, tests fail - see https://travis-ci.org/ory/ladon/builds/337514939#L590

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

aeneasr · 2018-02-06T09:31:22Z

manager_test_helper.go

 						found[got.GetID()]++
 					}
 				}
 			}

 			for _, f := range found {
+				//This assert is supposed to fail


That's not true, found is a map[string]int{} which has for every policy id a value of 1 so this can't fail. A better test would be something like this (pseudocode):

found := map[string]int{} for _, got := range pols { for _, expect := range TestManagerPolicies { if got.GetID() == expect.GetID() { DeepEquals(expect, got) found[got.GetID()]++ } } }

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

…nto WorkInProgress Simple merge

adhicoder · 2018-02-06T10:36:39Z

I added the conditions fields and the tests passed. I meant to keep the assert that way and forgot to change the comment. So here, I am comparing the resources and actions fields of the policies in the equality check to see that it is persisted correctly. Since the assert is passing in this case, it implies that the policies are persisted in the database correctly, right?
But in the endpoint where I am creating policies in another code, there is something wrong with the persistence of these policies in certain cases. I am not able to recreate the error. Why this anomaly?
Also, still not able to test locally with go test ./....

aeneasr · 2018-02-06T11:36:18Z

manager_test_helper.go

@@ -354,13 +374,15 @@ func TestHelperCreateGetDelete(s Manager) func(t *testing.T) {
 			found := map[string]int{}
 			for _, got := range pols {
 				for _, expect := range TestManagerPolicies {
-					if got.GetID() == expect.GetID() {


Could you please replace this with

for _, got := range pols { for _, expect := range TestManagerPolicies { if got.GetID() == expect.GetID() { assert.True(t, reflect.DeepEquals(expect, got)) found[got.GetID()]++ } } }

@adhicoder please do this

Still failing. Not sure why though.

That's ok, and was also the whole point of this PR (creating a sane failing test to find the bug you described). However, the output is still not conclusive enough (https://travis-ci.org/ory/ladon/builds/338007648#L605). Let's change assert.True(t, reflect.DeepEquals(expect, got)) to assert.ObjectsAreEqualValues(t, expect, got) which will print a better error message

aeneasr · 2018-02-06T11:37:48Z

manager_test_helper.go

@@ -354,13 +374,15 @@ func TestHelperCreateGetDelete(s Manager) func(t *testing.T) {
 			found := map[string]int{}
 			for _, got := range pols {
 				for _, expect := range TestManagerPolicies {
-					if got.GetID() == expect.GetID() {
+					//This is a modified equality check
+					if got.GetID() == expect.GetID() && reflect.DeepEqual(got.GetResources(), expect.GetResources()) && reflect.DeepEqual(got.GetActions(), expect.GetActions()) {
 						found[got.GetID()]++
 					}
 				}
 			}



Please add assert.Len(t, found, len(TestManagerPolicies)) here

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

adhicoder · 2018-02-06T13:08:40Z

I added the assert. Build fails saying map should have 14 items but has 0.

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

adhicoder · 2018-02-06T13:40:02Z

Paradoxically, the checks have now passed

aeneasr · 2018-02-06T13:46:06Z

Haha, that is very interesting. It sort of supports my suspicion that the bug is somewhere else (because apparently, the bug does not appear with proper tests).

Another possibility is that the bug is with the MySQL version. You should change the version here from 5.6 to 5.7.2. This will reproduce your environment 1:1. If tests still pass, it has to be some other error, most likely in your code.

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

aeneasr · 2018-02-06T20:26:20Z

So it seems like tests are passing with 5.7.2 as well - so something must be wrong in your usage or set up of ladon, sorry! Thank you for the PR though, I'll add your changes because they are quite valuable! The only thing is to please revert the last change (fc270fd) because I want this library to be compatible with MySQL 5.6

If you want, you can share some the code you had issues with with me, maybe I can spot if something's wrong.

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

adhicoder · 2018-02-07T05:49:41Z

Thank you, I have reverted the changes to the SQL version. I shall share the code that I had issues with soon, please see if you can spot the error.

aeneasr · 2018-02-07T08:00:13Z

Thank you! I will! Please post the code to the original issue :)

Adhithya Ravindra added 3 commits February 5, 2018 17:13

[WorkInProgress] Add two failing policies and equality check

160f4d8

[WorkInProgress] Add two failing policies and equality check

44c2c11

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

Merge branch 'WorkInProgress' of https://github.com/adhicoder/ladon i…

de43de0

…nto WorkInProgress Merging for signature change

aeneasr reviewed Feb 5, 2018

View reviewed changes

[WorkInProgress] Change one assert

9aee641

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

aeneasr reviewed Feb 6, 2018

View reviewed changes

Adhithya Ravindra added 3 commits February 6, 2018 15:50

[WorkInProgress] Changed the conditions for the two policies

128ecdd

[WorkInProgress] Changed the conditions for the two policies

fb2b62b

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

Merge branch 'WorkInProgress' of https://github.com/adhicoder/ladon i…

3c80d96

…nto WorkInProgress Simple merge

aeneasr reviewed Feb 6, 2018

View reviewed changes

Adhithya Ravindra added 2 commits February 6, 2018 18:04

[WorkInProgress] Added length assert

4526b47

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

[WorkInProgress] Modified length assert

bb5e986

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

Adhithya Ravindra added 2 commits February 6, 2018 18:54

[WorkInProgress] Assert with deepEqual

66e8c69

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

[WorkInProgress] Assert with ObjectsAreEqual

c080f53

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

[WorkInProgress] Change version of SQL

fc270fd

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

[WorkInProgress] Revert change in version of SQL

dd3092e

Signed-off-by: Adhithya Ravindra <Adhithya.Ravindra@gmail.com>

aeneasr merged commit f50a508 into ory:master Feb 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WorkInProgress] Add two failing policies and equality check #106

[WorkInProgress] Add two failing policies and equality check #106

adhicoder commented Feb 5, 2018

aeneasr Feb 5, 2018

adhicoder Feb 5, 2018

aeneasr Feb 6, 2018

aeneasr commented Feb 5, 2018

aeneasr Feb 6, 2018

adhicoder commented Feb 6, 2018

aeneasr Feb 6, 2018 •

edited

Loading

aeneasr Feb 6, 2018

adhicoder Feb 6, 2018

aeneasr Feb 6, 2018

aeneasr Feb 6, 2018

adhicoder commented Feb 6, 2018

adhicoder commented Feb 6, 2018

aeneasr commented Feb 6, 2018 •

edited

Loading

aeneasr commented Feb 6, 2018 •

edited

Loading

adhicoder commented Feb 7, 2018

aeneasr commented Feb 7, 2018

[WorkInProgress] Add two failing policies and equality check #106

[WorkInProgress] Add two failing policies and equality check #106

Conversation

adhicoder commented Feb 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aeneasr commented Feb 5, 2018

Choose a reason for hiding this comment

adhicoder commented Feb 6, 2018

aeneasr Feb 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adhicoder commented Feb 6, 2018

adhicoder commented Feb 6, 2018

aeneasr commented Feb 6, 2018 • edited Loading

aeneasr commented Feb 6, 2018 • edited Loading

adhicoder commented Feb 7, 2018

aeneasr commented Feb 7, 2018

aeneasr Feb 6, 2018 •

edited

Loading

aeneasr commented Feb 6, 2018 •

edited

Loading

aeneasr commented Feb 6, 2018 •

edited

Loading