Skip to content

Extract hosts #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

Extract hosts #1736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions osism/tasks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@

from osism import utils

# Regex pattern for extracting hosts from Ansible output
HOST_PATTERN = re.compile(r"^(ok|changed|failed|skipping|unreachable):\s+\[([^\]]+)\]")


class Config:
broker_connection_retry_on_startup = True
Expand Down Expand Up @@ -106,14 +109,18 @@ def log_play_execution(
# Get runtime version from YAML version file
runtime_version = get_container_version(worker)

# Use provided hosts or empty list
if hosts is None:
hosts = []

execution_record = {
"timestamp": datetime.now(timezone.utc).isoformat().replace("+00:00", "Z"),
"request_id": request_id,
"worker": worker,
"worker_version": runtime_version,
"environment": environment,
"role": role,
"hosts": hosts if isinstance(hosts, list) else [],
"hosts": hosts,
"arguments": arguments if arguments else "",
"result": result,
}
Expand Down Expand Up @@ -145,6 +152,7 @@ def run_ansible_in_environment(
auto_release_time=3600,
):
result = ""
extracted_hosts = set() # Local set for host deduplication

if type(arguments) == list:
joined_arguments = " ".join(arguments)
Expand Down Expand Up @@ -183,7 +191,7 @@ def run_ansible_in_environment(
worker=worker,
environment=environment,
role=role,
hosts=None, # Host extraction would require inventory parsing
hosts=None, # Hosts will be empty at start, filled at completion
arguments=joined_arguments,
result="started",
)
Expand Down Expand Up @@ -272,6 +280,13 @@ def run_ansible_in_environment(

while p.poll() is None:
line = p.stdout.readline().decode("utf-8")

# Extract hosts from Ansible output
match = HOST_PATTERN.match(line.strip())
if match:
hostname = match.group(2)
extracted_hosts.add(hostname) # Local set (automatic deduplication)

if publish:
utils.push_task_output(request_id, line)
result += line
Expand All @@ -284,7 +299,7 @@ def run_ansible_in_environment(
worker=worker,
environment=environment,
role=role,
hosts=None, # Host extraction would require inventory parsing
hosts=sorted(list(extracted_hosts)), # Direct pass of extracted hosts
arguments=joined_arguments,
result="success" if rc == 0 else "failure",
)
Expand Down