Skip to content

Conversation

sudhirmohanraj
Copy link

This pull request is to resolve #4

Changes

  • added a new test class for ReportGenerator that tests its functionality
  • added a utility test class which will help in testing
  • added myself as a contributor in authors.doc file.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling beb214b on sudhirmohanraj:Issue1 into fbaaa14 on oskopek:develop.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't generate the report into src/ - it pollutes the source directory. Create a temporary folder, or better yet, use Maven's target/test-classes/ or something related.

EDIT: This applies to all the occurrences below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oskopek makes sense will update it.

@oskopek
Copy link
Owner

oskopek commented Feb 27, 2014

@sudhirmohanraj I forgot to mention before - you should also add a licensing comment on top of the new files. Frankly I'm not really sure how you would go about managing the copyright thought...

Maybe something like this? We should try to stay as close to the original text as possible.

/*
------------------------------------------------------------------------
JavaANPR - Automatic Number Plate Recognition System for Java
------------------------------------------------------------------------

This file is a part of the JavaANPR, licensed under the terms of the
Educational Community License

Copyright (c) 2006-2007 Ondrej Martinsky. All rights reserved
Copyright (c) 2014 JavaANPR Development Team

This Original Work, including software, source code, documents, or
other related items, is being provided by the copyright holder(s)
subject to the terms of the Educational Community License. By
obtaining, using and/or copying this Original Work, you agree that you
have read, understand, and will comply with the following terms and
conditions of the Educational Community License:

Permission to use, copy, modify, merge, publish, distribute, and
sublicense this Original Work and its documentation, with or without
modification, for any purpose, and without fee or royalty to the
copyright holder(s) is hereby granted, provided that you include the
following on ALL copies of the Original Work or portions thereof,
including modifications or derivatives, that you make:

# The full text of the Educational Community License in a location
viewable to users of the redistributed or derivative work.

# Any pre-existing intellectual property disclaimers, notices, or terms
and conditions.

# Notice of any changes or modifications to the Original Work,
including the date the changes were made.

# Any modifications of the Original Work must be distributed in such a
manner as to avoid any confusion with the Original Work of the
copyright holders.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

The name and trademarks of copyright holder(s) may NOT be used in
advertising or publicity pertaining to the Original or Derivative Works
without specific, written prior permission. Title to copyright in the
Original Work and any associated documentation will at all times remain
with the copyright holders.

If you want to alter upon this work, you MUST attribute it in
a) all source files
b) on every place, where is the copyright of derivated work
exactly by the following label :

---- label begin ----
This work is a derivate of the JavaANPR. JavaANPR is a intellectual
property of Ondrej Martinsky. Please visit http://javaanpr.sourceforge.net
for more info about JavaANPR.
----  label end  ----

------------------------------------------------------------------------
                                         http://javaanpr.sourceforge.net
------------------------------------------------------------------------
 */

@sudhirmohanraj
Copy link
Author

updated. I used the same information as the one from other files.

@sudhirmohanraj
Copy link
Author

@oskopek updated the changes suggested.

oskopek added a commit that referenced this pull request Feb 28, 2014
Add test cases for ReportGenerator. Thanks to @sudhirmohanraj
@oskopek oskopek merged commit 96ac44e into oskopek:develop Feb 28, 2014
@oskopek
Copy link
Owner

oskopek commented Feb 28, 2014

Congratulations on your first JavaANPR pull request! Thank you for your contribution.

@sudhirmohanraj
Copy link
Author

thanks. Look forward to being involved more.

@sudhirmohanraj sudhirmohanraj deleted the Issue1 branch March 1, 2014 02:36
@oskopek oskopek added this to the 1.3.0 milestone Mar 31, 2014
@oskopek oskopek modified the milestone: 2.0.0 Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants