-
Notifications
You must be signed in to change notification settings - Fork 114
Issue1-Add test cases for ReportGenerator. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't generate the report into src/
- it pollutes the source directory. Create a temporary folder, or better yet, use Maven's target/test-classes/
or something related.
EDIT: This applies to all the occurrences below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oskopek makes sense will update it.
@sudhirmohanraj I forgot to mention before - you should also add a licensing comment on top of the new files. Frankly I'm not really sure how you would go about managing the copyright thought... Maybe something like this? We should try to stay as close to the original text as possible.
|
updated. I used the same information as the one from other files. |
@oskopek updated the changes suggested. |
Add test cases for ReportGenerator. Thanks to @sudhirmohanraj
Congratulations on your first JavaANPR pull request! Thank you for your contribution. |
thanks. Look forward to being involved more. |
This pull request is to resolve #4