Extract nested class from plate vertical graph #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskopek
requested changes
Dec 23, 2016
| public class PeakComparator implements Comparator<Peak> { | ||
| private PlateVerticalGraph graphHandle = null; | ||
|
|
||
| public PeakComparator(PlateVerticalGraph graph) { |
There was a problem hiding this comment.
Let's only pass yValues into this comparator. It will be easier to test and more encapsulated.
There was a problem hiding this comment.
Okay, will change it!
|
|
||
| @Before | ||
| public void setup() { | ||
| PlateVerticalGraph plateVerticalGraph = mock(PlateVerticalGraph.class); |
There was a problem hiding this comment.
You don't need this mock after you change the parameters in the comparator.
There was a problem hiding this comment.
Okay, will change it!
|
|
||
| @Override | ||
| public int compare(Peak peak1, Peak peak2) { | ||
| return Double.compare(getPeakValue(peak1), getPeakValue(peak2)); |
There was a problem hiding this comment.
There's a bug on this line - you reversed the order of peak1 and peak2 in the comparison. That's why the tests are failing. Also, fix your added test after you switch these.
There was a problem hiding this comment.
Sorry, will change it!
…it to PeakComparator and simplified compare method. Extracting PeakComparer also required extracting Peak from Graph. Changed Plate, CatSnapShot, Band and BandGraph to reflect this. Removed unused field handle from PlateVerticalGraph.
…t that). Made PeakComparator take a vector of floats instead of a PlateVerticalGraph in its constructor.
FridaTveit
force-pushed
the
ExtractNestedClassFromPlateVerticalGraph
branch
from
82b491d to
8738dcd
Compare
oskopek
approved these changes
Dec 23, 2016
|
Thanks for all the PRs @FridaTveit :) Merry Christmas 🎄 |
|
Merry Christmas! :) 🎄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted Peak from Graph and extracted PeakComparer from PlateVerticalGraph. Added unit tests for PeakComparer (renamed to PeakComparator).