Remove duplicate of peak comparator #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeakComparer which was extracted from PlaeVerticalGraph. I have compared the old PeakComparer which was in PlateVerticalGraph with the one in CarSnapshotGraph and they were the same. The old PeakComparer has been removed. Also removed unneeded uses of 'this' in CarSnapshopGraph as per issue oskopek#41.
…ate. Removed unneeded uses of 'this' in BandGraph as per issue oskopek#41.
oskopek
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate of PeakComparator (extracted from PlateVerticalGraph in pull request #50 ) in BandGraph and CarSnapshotGraph. Also removed unneeded uses of 'this' in BandGraph and CarSnapshotGraph as per issue #41.
I have compared the PeakComparer classes that were present in BandGraph and CarSnapshotGraph and they are definitely the same as the PeakComparer which I extracted from PlateVerticalGraph.