Expand ts #61
Open
Expand ts #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration in ProjectPathModal.tsx. begin setting up interface for redux store global state
…terface from Interfaces.ts to index.d.ts in Preload process, finish altering frontend code using this interface
…st related useSelector invocations on frontend
…ces), adjust type assignment in frontend components accordingly
…pe, reconcile discrepency btwn position type of NodeProps and HandleProps b y assigning default position type, explicitly export Componenets and Server interfaces from stateInterfaces.ts to be imported in Preload process as return values of 'send' invocation. Also create SendD ata type in this process as conditional type of 'data' arg passed in to send method. Remove duplicate id prop from input tag in Header.tsx.
… files to stateInterface file, convert return type from Promise in send method to SendReturnObject, delete unused code in global.d.ts
…line 261: change componentCode arg to componentCode.data. componentController.js line 303: set res.locals.componentCode to just fileCode instead of fileCode.data. (this mix up happened in the process of adding descriptive types)
…odButtonContainer component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
convert all TypeScript “any" types to specific types
CHANGES
add 'interfaces' folder to 'renderer/src' folder, containing interfaces that collectively cover all state in the redux store, as well a couple type definitions related to IPC
define types of parameters and return values sent via IPC in 'preload/index.d.ts'
add keys to 'MethodButton' components returned via array mapping from the 'MethodButtonContainer' component
TESTING INFORMATION
run “npm run typecheck”
there should be no errors
run “npm run make” to compile code and package it into an application file
unzip and run this application file
test all application features on a couple projects you’ve previously used for testing