Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gazebo9] More enhancement for Windows build #2789

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jul 14, 2020

@scpeters scpeters added the 9 Gazebo 9 label Jul 15, 2020
@j-rivero j-rivero self-requested a review July 20, 2020 17:40
@j-rivero
Copy link
Contributor

j-rivero commented Aug 7, 2020

Thanks Sean! changes looks good to me. Let me run another round of CI before merging. @osrf-jenkins run tests

@j-rivero
Copy link
Contributor

j-rivero commented Aug 7, 2020

The abi-checker killed the memory in CI, I'm not worried about. The Mac build is waiting #2809. Windows is happy. Let's wait a bit more for the linux ones.

@seanyen
Copy link
Contributor Author

seanyen commented Aug 7, 2020

Thanks! And hope this can be forward-port to Gazebo11 if they also make sense there. :)

@chapulina chapulina merged commit af30f74 into gazebosim:gazebo9 Aug 11, 2020
Tobias-Fischer added a commit to Tobias-Fischer/gazebo that referenced this pull request May 2, 2021
Tobias-Fischer added a commit to Tobias-Fischer/gazebo that referenced this pull request May 2, 2021
scpeters added a commit that referenced this pull request Oct 28, 2021
* Forward port #2789 part 1
* Forward port #2789 part 2
* Fix line length and compiler warning

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9 Gazebo 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants