Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to gazebo upstream hydrodynamics plugin #258

Closed
wants to merge 2 commits into from

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Oct 7, 2022

Depends on gazebosim/gz-sim#1692 getting ported to gz-sim7.

This PR adds the changes so we can start using the upstream hydrodynamics plugin and removes the local one from this repo.

@arjo129
Copy link
Member

arjo129 commented Oct 10, 2022

Lots of failing tests here. I will take a look at this.

          4 - CurrentsTest.TestGlobalCurrent (Failed)
	  5 - SurfaceWindsTest.WindAtSurface (Failed)
	  9 - VehicleStateTest.ThrustState (Failed)
	 10 - VehicleStateTest.ThrustAndTurnState (Failed)
	 15 - AcousticComms.MultiVehicleTest (Failed)
	 24 - BuoyancyActionTest.Sink (Failed)
	 26 - ElevatorActionTest.Sink (Failed)
	 27 - MassShifterTest.DownwardTilt (Failed)

@arjo129
Copy link
Member

arjo129 commented Nov 15, 2022

Once gazebosim/gz-sim#1794 is merged and we switch back to using the main branch, we should be good to merge this.

@marcoag marcoag changed the title Switching to gazebo upstream hydrynamics plugin Switching to gazebo upstream hydrodynamics plugin Nov 21, 2022
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are:

         9 - VehicleStateTest.ThrustState (Failed)
	 10 - VehicleStateTest.ThrustAndTurnState (Failed)
	 16 - AHRSTest.FrameConventionsAreCorrect (Failed)
	 24 - BuoyancyActionTest.Sink (Failed)
	 27 - MassShifterTest.DownwardTilt (Failed)

Overall, we see slight regression in the numerical correctness of the equations. On the other hand, we should still be able to control the vehicle. Hence, I'm approving this. If we want we can widen tolerances on the aforementioned tests. Also the hydrodynamics tests pass so I'm happy.

@hidmic
Copy link
Collaborator

hidmic commented Dec 14, 2022

16 - AHRSTest.FrameConventionsAreCorrect (Failed)

Should be fixed by #276.

@arjo129
Copy link
Member

arjo129 commented Dec 15, 2022

Closing because we don't have enough time. Its safer to guarantee that things work. Since the hydrodynamics here works.

@arjo129 arjo129 closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants