Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-release repos, Fortress is stable #86

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

chapulina
Copy link
Contributor

No need for the pre-release repo anymore. This shouldn't really be changing anything at this point, but it's safer.

Once we go to Garden (#54 ), we should add the nightly repo.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@arjo129
Copy link
Member

arjo129 commented Nov 22, 2021

Will this mean that if we upstream a bugfix/feature, there will need to be a new minor release every time?

@chapulina
Copy link
Contributor Author

Will this mean that if we upstream a bugfix/feature, there will need to be a new minor release every time?

Yeah, we only build nightlies for the unstable version, which is Garden now. Pre-releases and stable releases need to be manually triggered.

Once we go to Garden we should use nightlies again. I just wanted to remove this so there's no impression that we're actually using any pre-releases, because we aren't.

Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine as is.

I was going to ask what the harm is of having the prereleases available if it's not going to be updated until we go to garden. Thus if we're planning to go to garden in the near future we could just keep it there.

But then I'd like to refactor this into a multi-stage build or parameterize this so cleaning this out for now makes sense either way..

@chapulina chapulina merged commit 2145afd into main Nov 23, 2021
@chapulina chapulina deleted the chapulina/no_prerelease branch November 23, 2021 03:26
@caguero caguero mentioned this pull request Nov 2, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants