Use keyword arguments only for protocol_class invocations #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Feb 24, 2019
nuclearsandwich
added a commit
to ros/rosdistro
that referenced
this pull request
Apr 11, 2019
Increasing version of package(s) in repository `osrf_pycommon` to `0.1.7-1`: - upstream repository: https://github.com/osrf/osrf_pycommon.git - release repository: https://github.com/ros2-gbp/osrf_pycommon-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0.dev2` - previous version for package: `null` ## osrf_pycommon ``` * Use keyword arguments only for protocol_class invocations (#52 <osrf/osrf_pycommon#52>) * Contributors: Daniel Stonier ```
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
) Increasing version of package(s) in repository `osrf_pycommon` to `0.1.7-1`: - upstream repository: https://github.com/osrf/osrf_pycommon.git - release repository: https://github.com/ros2-gbp/osrf_pycommon-release.git - distro file: `dashing/distribution.yaml` - bloom version: `0.8.0.dev2` - previous version for package: `null` ## osrf_pycommon ``` * Use keyword arguments only for protocol_class invocations (ros#52 <osrf/osrf_pycommon#52>) * Contributors: Daniel Stonier ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfixes a problem in osrf_pycommon/process_utils/async_execute_process_asyncio/impl.py#L67-L68 which fails when operating on a protocol class that only uses keyword arguments.
See ros2/launch/issues/188 for more details. The traceback there if tty is enabled, which triggers this code:
Since positional ordering does not seem to be relevant here and keyword args are always more readable, I've updated the call to use keywords and the tests to force use of keyword only calls in this PR.