Skip to content

Bump CMake version of googletest for humble #95

@christophfroehlich

Description

@christophfroehlich

#94 bumps the cmake_minimum_version tags of the two packages, but this is not sufficient for humble/ubuntu jammy:

github runner ubuntu-22.04 got a new cmake version, which makes the source build fail
actions/runner-images#12958

2025-09-17T03:34:37.2019894Z CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
2025-09-17T03:34:37.2021080Z   Compatibility with CMake < 3.10 will be removed from a future version of
2025-09-17T03:34:37.2021866Z   CMake.
2025-09-17T03:34:37.2022326Z 
2025-09-17T03:34:37.2022878Z   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
2025-09-17T03:34:37.2023655Z   to tell CMake that the project requires at least <min> but has been updated
2025-09-17T03:34:37.2024310Z   to work with policies introduced by <max> or earlier.
2025-09-17T03:34:37.2024929Z 
2025-09-17T03:34:37.2024935Z 
2025-09-17T03:34:37.2025102Z -- The C compiler identification is GNU 11.4.0
2025-09-17T03:34:37.2025561Z -- The CXX compiler identification is GNU 11.4.0
2025-09-17T03:34:37.2025997Z -- Detecting C compiler ABI info
2025-09-17T03:34:37.2026377Z -- Detecting C compiler ABI info - done
2025-09-17T03:34:37.2026798Z -- Check for working C compiler: /usr/bin/cc - skipped
2025-09-17T03:34:37.2027223Z -- Detecting C compile features
2025-09-17T03:34:37.2027590Z -- Detecting C compile features - done
2025-09-17T03:34:37.2027980Z -- Detecting CXX compiler ABI info
2025-09-17T03:34:37.2028694Z -- Detecting CXX compiler ABI info - done
2025-09-17T03:34:37.2029180Z -- Check for working CXX compiler: /usr/bin/c++ - skipped
2025-09-17T03:34:37.2029638Z -- Detecting CXX compile features
2025-09-17T03:34:37.2030019Z -- Detecting CXX compile features - done
2025-09-17T03:34:37.2030490Z -- Could NOT find libdw (missing: LIBDW_LIBRARY LIBDW_INCLUDE_DIR) 
2025-09-17T03:34:37.2031076Z -- Could NOT find libbfd (missing: LIBBFD_LIBRARY LIBBFD_INCLUDE_DIR) 
2025-09-17T03:34:37.2031939Z -- Could NOT find libdwarf (missing: LIBDWARF_LIBRARY LIBDWARF_INCLUDE_DIR LIBELF_LIBRARY LIBELF_INCLUDE_DIR) 
2025-09-17T03:34:37.2033347Z -- Found Backward: /home/runner/work/control_toolbox/control_toolbox/ros_ws/src/osrf_testing_tools_cpp/osrf_testing_tools_cpp/src/memory_tools/vendor/bombela/backward-cpp
2025-09-17T03:34:37.2034637Z -- googletest version '1.10.0.2' selected, of versions: '1.10.0;1.10.0.1;1.10.0.2'
2025-09-17T03:34:37.2036034Z -- building googletest from '/home/runner/work/control_toolbox/control_toolbox/ros_ws/src/osrf_testing_tools_cpp/osrf_testing_tools_cpp/vendor/google/googletest/release-1.10.0.2.tar.gz'...
2025-09-17T03:34:37.2037338Z CMake Error at CMakeLists.txt:4 (cmake_minimum_required):
2025-09-17T03:34:37.2037918Z   Compatibility with CMake < 3.5 has been removed from CMake.
2025-09-17T03:34:37.2038426Z 
2025-09-17T03:34:37.2038961Z   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
2025-09-17T03:34:37.2039663Z   to tell CMake that the project requires at least <min> but has been updated
2025-09-17T03:34:37.2040269Z   to work with policies introduced by <max> or earlier.
2025-09-17T03:34:37.2040595Z 
2025-09-17T03:34:37.2040859Z   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
2025-09-17T03:34:37.2041246Z 
2025-09-17T03:34:37.2041251Z 
2025-09-17T03:34:37.2041611Z CMake Error at cmake/osrf_testing_tools_cpp_extract_and_build_googletest.cmake:53 (message):
2025-09-17T03:34:37.2042254Z   CMake step for googletest failed: 1
2025-09-17T03:34:37.2042616Z Call Stack (most recent call first):
2025-09-17T03:34:37.2043302Z   cmake/osrf_testing_tools_cpp_require_googletest.cmake:178 (osrf_testing_tools_cpp_extract_and_build_googletest)
2025-09-17T03:34:37.2044286Z   cmake/osrf_testing_tools_cpp_require_googletest.cmake:57 (_osrf_testing_tools_cpp_require_googletest)
2025-09-17T03:34:37.2045045Z   CMakeLists.txt:24 (osrf_testing_tools_cpp_require_googletest)
2025-09-17T03:34:37.2045399Z 
2025-09-17T03:34:37.2045404Z 
2025-09-17T03:34:37.2045579Z -- Configuring incomplete, errors occurred!
2025-09-17T03:34:37.2045978Z -- Configuring incomplete, errors occurred!
2025-09-17T03:34:37.2046323Z ---
2025-09-17T03:34:37.2046561Z --- stderr: osrf_testing_tools_cpp

I don't understand the mechanism with the shipped googletest versions, I can't help with a PR here :/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions