-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still trying out the demo but some early comments
Co-authored-by: Yadu <yadunund@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managed to successfully run the secured demo and it works great! Thanks for making the necessary changes. Could you update the changelogs before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tmux script works well with the proposed change. We can merge this in once the Rviz segfault is fixed
Also, what do you think of adding Line 22 in 8e7b734
This we can we ensure the |
Co-authored-by: Yadu <yadunund@openrobotics.org>
Rviz segfault has been fixed, it seems that
Regarding the version of |
Rviz is no longer crashing 👍 But after a couple minutes of running the demo I observe this message on all the tmux windows
The simulation becomes unresponsive afterwards.
That is a fair point, we can leave it out for now. |
Just created a separate issue for the handshake as it's not directly related to the demo itself: #159 I will follow up on fixes with cyclonedds and update there. |
Adding the files and instructions needed for a secured run of the office demo.