Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Secured ros2 office demo #135

Merged
merged 20 commits into from
Nov 10, 2020
Merged

Secured ros2 office demo #135

merged 20 commits into from
Nov 10, 2020

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 17, 2020

Adding the files and instructions needed for a secured run of the office demo.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still trying out the demo but some early comments

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
marcoag and others added 6 commits September 23, 2020 09:16
Co-authored-by: Yadu <yadunund@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to successfully run the secured demo and it works great! Thanks for making the necessary changes. Could you update the changelogs before merging?

@marcoag
Copy link
Member Author

marcoag commented Oct 14, 2020

@Yadunund could you test the tmux script?

For your reference: 85f4bfb

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tmux script works well with the proposed change. We can merge this in once the Rviz segfault is fixed

@Yadunund
Copy link
Member

Also, what do you think of adding rmw_cyclonedds and cyclonedds to the repos list under thirdparty namespace?

thirdparty/menge_core:

This we can we ensure the 0.7.4 tag of rmf_cyclonedds gets cloned during setup.

Marco A. Gutiérrez and others added 3 commits October 30, 2020 14:56
@marcoag
Copy link
Member Author

marcoag commented Oct 30, 2020

Rviz segfault has been fixed, it seems that cyclonedds was segfaulting because a subscription permission was missing. cyclonedds should throw a message instead, I believe it does usually. Will further investigate and report this.

Also, what do you think of adding rmw_cyclonedds and cyclonedds to the repos list under thirdparty namespace?

thirdparty/menge_core:

This we can we ensure the 0.7.4 tag of rmf_cyclonedds gets cloned during setup.

cyclonedds is only relevant to the SROS 2 demo I would say we leave it out as it's not a mandatory repo?

Regarding the version of cyclonedds, we shouldn't be using 0.7.4 but the latest (0.7.5), I reported the building issue faced:

ros2/rmw_cyclonedds#261

@Yadunund
Copy link
Member

Yadunund commented Nov 2, 2020

Rviz is no longer crashing 👍

But after a couple minutes of running the demo I observe this message on all the tmux windows

fsm: handshake (lguid=e0e9560c:e7a9052e:270b167b:1c1 rguid=d52568ea:4d08201b:d6a90132:1c1) failed: (1) Timed out

The simulation becomes unresponsive afterwards.

cyclonedds is only relevant to the SROS 2 demo I would say we leave it out as it's not a mandatory repo?

That is a fair point, we can leave it out for now.

@marcoag
Copy link
Member Author

marcoag commented Nov 6, 2020

Just created a separate issue for the handshake as it's not directly related to the demo itself: #159

I will follow up on fixes with cyclonedds and update there.

@marcoag marcoag requested a review from Yadunund November 6, 2020 10:12
@marcoag marcoag merged commit 3250d17 into master Nov 10, 2020
@marcoag marcoag deleted the feature/sros2_office branch November 10, 2020 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants