-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noetic support #93
Noetic support #93
Conversation
Commented out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some code still enabled for Actuators
:
ros_ign_bridge/test/publishers/ign_publisher.cpp:160: auto actuators_pub = node.Advertise<ignition::msgs::Actuators>("actuators");
ros_ign_bridge/test/publishers/ign_publisher.cpp:161: ignition::msgs::Actuators actuators_msg;
ros_ign_bridge/test/publishers/ign_publisher.cpp:162: ros_ign_bridge::testing::createTestMsg(actuators_msg);
ros_ign_bridge/test/publishers/ign_publisher.cpp:214: actuators_pub.Publish(actuators_msg);
ros_ign_bridge/test/launch/test_ros_subscriber.launch:33: <!-- /actuators@mav_msgs/Actuators@ignition.msgs.Actuators -->
ros_ign_bridge/test/launch/test_ign_subscriber.launch:28: /actuators@mav_msgs/Actuators@ignition.msgs.Actuators
ros_ign_bridge/test/test_utils.h:1425: void createTestMsg(ignition::msgs::Actuators &_msg)
ros_ign_bridge/test/test_utils.h:1442: void compareTestMsg(const ignition::msgs::Actuators &_msg)
ros_ign_bridge/test/test_utils.h:1444: ignition::msgs::Actuators expected_msg;
Do we want to keep it?
Also found references to other ROS releases or Ignition versions from Blueprint. I made a branch chapulina/noetic_jrivero
Signed-off-by: Louise Poubel <louise@openrobotics.org>
2649c74
to
c21966a
Compare
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
I left the Ignition parts since they're already working. They're not very useful without the ROS side though. I guess at least we can keep it from rotting. If you think it's best to comment it out I can do that.
Thanks, merged it in. I also rebased the |
Nothing important, I thought on someone listing gz topics and found the Actuator in there. A part from a bit of compile/runtime overhead without real use. |
Changes since Melodic: