-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchForStuff: add logic to find urdfdom without pkg-config #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thank you.
sorry for the delay in reviewing this; do you mind signing your commit? you can optionally rebase at the same time if you want |
Codecov Report
@@ Coverage Diff @@
## sdf9 #245 +/- ##
==========================================
- Coverage 86.40% 86.27% -0.14%
==========================================
Files 59 59
Lines 9053 9177 +124
==========================================
+ Hits 7822 7917 +95
- Misses 1231 1260 +29
Continue to review full report at Codecov.
|
Sorry, I had missed your reply. |
we added the DCO bot which checks that commits have a sign-off message (use |
b222dba
to
ac620c4
Compare
Done! |
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
ac620c4
to
cb3bfbc
Compare
…im#245) Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
…im#245) Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
This is useful for vcpkg packaging.