-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heightmap class #388
Add Heightmap class #388
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
looks ok to me; I'll look into how to add it to ign-physics; it will probably be similar to how meshes are handled, using |
In case it helps, this is how I'm using |
I'm working on the If it's still undecided, I guess I could leave this as it is and use the |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This PR is working with gazebosim/gz-sim#487. I still have some details to fix on that one, but I think the API on this one is settled, so I'm opening it for review, @scpeters. On a related note, because |
Codecov Report
@@ Coverage Diff @@
## sdf9 #388 +/- ##
==========================================
+ Coverage 86.43% 86.68% +0.24%
==========================================
Files 60 61 +1
Lines 9304 9516 +212
==========================================
+ Hits 8042 8249 +207
- Misses 1262 1267 +5
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
Resolves #382.
Added a C++ API for heightmap geometries that matches the XML spec.
I don't plan on changing the PR, but I'd like to see it working with
ign-gazebo
before merging, so I'll keep it as a draft while we work on the other parts.