Add support for building static library #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
1fcdaad
to
ebe9b20
Compare
4 tasks
madebr
reviewed
Oct 19, 2020
joxoby
force-pushed
the
add_static_lib_support
branch
from
77ea275
to
5c9a755
Compare
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com> Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
5c9a755
to
4c430aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 60 60
Lines 9341 9341
=======================================
Hits 8163 8163
Misses 1178 1178 Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
mjcarroll
reviewed
Oct 22, 2020
traversaro
reviewed
Oct 23, 2020
Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
a3e445b
to
be8028a
Compare
madebr
reviewed
Oct 23, 2020
Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
49a7a14
to
4ec13df
Compare
Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
db835a8
to
92a9813
Compare
madebr
reviewed
Oct 25, 2020
include/sdf/system_util.hh
Outdated
Comment on lines
30
to
34
| #ifdef __GNUC__ | ||
| #define SDFORMAT_VISIBLE __attribute__ ((dllexport)) | ||
| #else | ||
| #define SDFORMAT_VISIBLE __declspec(dllexport) | ||
| #endif |
There was a problem hiding this comment.
mingw supports __declspec(dllexport) and __declspec(dllimport)
See http://www.mingw.org/wiki/exporting_a_class_from_a_dll_for_multiple_instantiations
A special case for __GNUC__ is not needed, imho.
Signed-off-by: Juan Oxoby <juan@vicarious.com>
joxoby
force-pushed
the
add_static_lib_support
branch
from
6279c31
to
b5a8b1e
Compare
mjcarroll
approved these changes
Nov 9, 2020
scpeters
approved these changes
Nov 23, 2020
scpeters
added a commit
to scpeters/ign-cmake
that referenced
this pull request
Dec 29, 2021
Port of gazebosim/sdformat#394 to ign-cmake2. This publicly defines the *_STATIC_DEFINE symbol for a library target if BUILD_SHARED_LIBS is Off. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
7 tasks
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 29, 2021
Restore functionality of gazebosim#394. Submitted a fix upstream in gazebosim/gz-cmake#203. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merged
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Dec 29, 2021
Restore functionality of gazebosim#394. Submitted a fix upstream in gazebosim/gz-cmake#203. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.