Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added render_order to material #446

Merged
merged 5 commits into from
Dec 28, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Dec 22, 2020

This PR is part of the effort to avoid z-fighting between coplanar meshes.

Related with gazebosim/gz-rendering#188

Signed-off-by: ahcorde ahcorde@gmail.com

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #446 (430e76f) into sdf10 (7dbf121) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf10     #446      +/-   ##
==========================================
+ Coverage   87.54%   87.56%   +0.01%     
==========================================
  Files          61       61              
  Lines        9357     9365       +8     
==========================================
+ Hits         8192     8200       +8     
  Misses       1165     1165              
Impacted Files Coverage Δ
src/Material.cc 98.17% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbf121...430e76f. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a question about documentation.

sdf/1.7/material.sdf Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
src/Material_TEST.cc Outdated Show resolved Hide resolved
sdf/1.7/material.sdf Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chapulina chapulina merged commit 8063f0c into gazebosim:sdf10 Dec 28, 2020
scpeters added a commit to scpeters/sdformat that referenced this pull request May 17, 2021
* added to 1.7 spec in gazebosim#446

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request May 19, 2021
* sdf 1.8: Add <double_sided> to material from #410
* sdf 1.8: Add lightmap to 1.8 spec from #429
* sdf 1.8: document Add L16 camera pixel format from #487

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* sdf 1.8: Decrease far clip lower bound from #435

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* sdf 1.8: Added render_order to material from #446

Signed-off-by: ahcorde <ahcorde@gmail.com>

* sdf 1.8: Add camera type aliases to docs. from #514
* sdf 1.8: Improve docs of collision_bitmask from #521

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* sdf 1.8: support nested models in @attached_to from #316

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants