-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use action-ignition-ci #452
Conversation
Revives gazebosim#266. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 63 63
Lines 9622 9622
=======================================
Hits 8432 8432
Misses 1190 1190 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I see the code checker has some errors that aren't causing the build to fail:
[src/ScopedGraph.hh:85]: (error) syntax error
[src/ScopedGraph.hh:85]: (error) syntax error
[src/Utils.cc:79]: (style) The function 'isValidFrameReference' is never used.
[src/Types.cc:83]: (style) The function 'operator<<' is never used.
I think that's probably something to be fixed in code_check.sh
.
We could probably also add Focal CI, that's just using the focal
branch of the action.
I'm curious about the long-term plan, are we going to keep the action defined here? https://github.com/osrf/sdformat/blob/master/.github/workflows/linux-ubuntu-bionic.yml |
I think we can delete that workflow. I'll get back to it for sure next week when I return from vacation; otherwise someone else can take this over |
👍 |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Revives #266.
Signed-off-by: Steve Peters scpeters@openrobotics.org