Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comms tests failing (for me) #7

Closed
osrf-migration opened this issue Sep 14, 2015 · 2 comments
Closed

Comms tests failing (for me) #7

osrf-migration opened this issue Sep 14, 2015 · 2 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Brian Gerkey (Bitbucket: Brian Gerkey, GitHub: gerkey).


I see the following tests fail on default:

[  FAILED  ] 4 tests, listed below:
[  FAILED  ] CommsTest.HalfMsgsDrop
[  FAILED  ] CommsTest.TemporaryOutage
[  FAILED  ] CommsTest.PermanentOutage
[  FAILED  ] CommsTest.OutagesAndDrops

The problem seems to be that expected message counts, which determined randomly, but which should be deterministic given a constant seed (which is set), don't agree. I get the following values reliably:

/home/gerkey/code/swarm/swarm/test/integration/comms_plugin.cc:173: Failure
Value of: expectedNumMsgs
  Actual: 347
Expected: this->numMsgsRecv
Which is: 354
[Dbg] [ServerFixture.cc:118] ServerFixture::Unload
[  FAILED  ] CommsTest.HalfMsgsDrop (1859 ms)
/home/gerkey/code/swarm/swarm/test/integration/comms_plugin.cc:173: Failure
Value of: expectedNumMsgs
  Actual: 470
Expected: this->numMsgsRecv
Which is: 442
[Dbg] [ServerFixture.cc:118] ServerFixture::Unload
[  FAILED  ] CommsTest.TemporaryOutage (1854 ms)
/home/gerkey/code/swarm/swarm/test/integration/comms_plugin.cc:173: Failure
Value of: expectedNumMsgs
  Actual: 296
Expected: this->numMsgsRecv
Which is: 229
[Dbg] [ServerFixture.cc:118] ServerFixture::Unload
[  FAILED  ] CommsTest.PermanentOutage (1859 ms)
/home/gerkey/code/swarm/swarm/test/integration/comms_plugin.cc:173: Failure
Value of: expectedNumMsgs
  Actual: 426
Expected: this->numMsgsRecv
Which is: 429
[Dbg] [ServerFixture.cc:118] ServerFixture::Unload
[  FAILED  ] CommsTest.OutagesAndDrops (1855 ms)
@osrf-migration
Copy link
Author

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


See pull request #26

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "new" to "resolved"

Merged in issue_7 (pull request #26)

Fix issue #7

→ <<cset 5ce3308>>

@osrf-migration osrf-migration added major bug Something isn't working labels May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant