Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: repo/file interface for Scorecard library #462

Closed
azeemshaikh38 opened this issue May 17, 2021 · 5 comments · Fixed by #951
Closed

Feature: repo/file interface for Scorecard library #462

azeemshaikh38 opened this issue May 17, 2021 · 5 comments · Fixed by #951
Assignees
Labels
kind/enhancement New feature or request

Comments

@azeemshaikh38
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Scorecard today is limited to run on GitHub repositories only. We should expand this support to handle local files and other VCS like GitLab, BitBucket etc.

Describe the solution you'd like
Create an interface RepoClient:

type RepoClient interface {
  Commits()
  File()
  ...
}

We need to look into our current code and sketch out all the required methods needed in this interface. Update our code bit-by-bit to use this interface instead of directly relying on GitHub API.

Under the hood use GitHubClient/LocalClient/GitLabClient which implements this interface and can fit clients needs.

@azeemshaikh38 azeemshaikh38 added the kind/enhancement New feature or request label May 17, 2021
@azeemshaikh38
Copy link
Contributor Author

@oliverchang
Copy link
Contributor

+1. Sounds great!

@inferno-chromium
Copy link
Contributor

+1, this would be awesome, and we definitely need localclient support. some checks might not be applicable when provided a local repo, but we need to add some skip state for those (instead of fail).

@naveensrinivasan
Copy link
Member

+1, this would be awesome, and we definitely need localclient support. some checks might not be applicable when provided a local repo, but we need to add some skip state for those (instead of fail).

+1. Great!!

@laurentsimon
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants