🐛 Licenses: Get License SPDXId from GitLab API #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update repoclient * Get SPDXId from `key` field in GitLab Projects API * Update e2etest repos Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
==========================================
- Coverage 72.63% 63.73% -8.91%
==========================================
Files 183 183
Lines 12930 12932 +2
==========================================
- Hits 9392 8242 -1150
- Misses 3019 4232 +1213
+ Partials 519 458 -61 |
spencerschrock
approved these changes
Aug 22, 2023
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
temporarily deployed
to
integration-test
GitHub Actions
Inactive
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* Fix licenses check * Update repoclient * Get SPDXId from `key` field in GitLab Projects API * Update e2etest repos Signed-off-by: Raghav Kaul <raghavkaul@google.com> * add test Signed-off-by: Raghav Kaul <raghavkaul@google.com> * stricter regex Signed-off-by: Raghav Kaul <raghavkaul@google.com> --------- Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updates the GitLab client so that we can get SPDXId from the GitLab API. A software license's SPDXId allows us to determine whether a GitLab repo's License is FSF/OSI-recognized, and get the last 1/10 points on the License check, which was previously impossible for GitLab repos.
Fixes #3333.