🐛 ignore Go stdlib vulns #3925
Merged
🐛 ignore Go stdlib vulns #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3925 +/- ##
==========================================
- Coverage 75.11% 70.51% -4.60%
==========================================
Files 234 234
Lines 15860 15864 +4
==========================================
- Hits 11913 11187 -726
- Misses 3187 3967 +780
+ Partials 760 710 -50 |
naveensrinivasan
approved these changes
Mar 6, 2024
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix / e2e test fix
What is the current behavior?
Go stdlib vulns are reported (since osv scanner 1.4 i think)
What is the new behavior (if this is a feature change)?**
Dont surface Go stdlib vulns. Whether or not a project is affected is a more complicated question than the version declared in the Go directive.
Which issue(s) this PR fixes
Fixes #3891
As well as our e2e tests:
https://github.com/ossf/scorecard/actions/runs/8177010131/job/22357695449#step:9:23142
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)