🌱 Require minimum version of Go 1.22.0 #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one of our dependencies now requires 1.22. Additionally, with the Go 1.23 release, Go 1.21 is no longer supported. Due to the loopvar changes, I'm submitting this as a standalone change. https://go.dev/doc/go1.22 Signed-off-by: Spencer Schrock <sschrock@google.com>
This wasn't included in b314490, because we didn't redeclare the loopvar with `tt := tt`, which is now done by default in Go 1.22.0. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
changed the title
|
We could always look at new Go 1.22 golangci-lint linters in the future too: |
justaugustus
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
go directive bump
What is the current behavior?
Go 1.21 is the minimum version required to compile Scorecard or use it as a library.
What is the new behavior (if this is a feature change)?**
Go 1.22.0 is now the minimum version.
At least one of our dependencies now requires 1.22. Additionally, with the Go 1.23 release, Go 1.21 is no longer supported. Due to the loopvar changes, I'm submitting this as a standalone change.
Which issue(s) this PR fixes
Unblocks #4319
Special notes for your reviewer
Note this is different from #3859 or #4300 which update our toolchain versions.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)