Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update SPDX license list, source for license data #4323

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

lelia
Copy link
Contributor

@lelia lelia commented Aug 30, 2024

What kind of change does this PR introduce?

What is the current behavior?

The outdated list of licenses causes some users to experience lower scores on License checks, in addition including licenses that are not FSF/OSI-approved.

What is the new behavior (if this is a feature change)?**

The updated list of licenses should help prevent these issues.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #4031

Special notes for your reviewer

For now, this just updates the list of licenses. A future enhancement can be added to programmatically fetch the licenses from the SPDX repo, and format the data in the way that fsfOsiApprovedLicenseMap expects.

Does this PR introduce a user-facing change?

Updates list of supported SDPX licenses to include latest data.

Signed-off-by: lelia <le1ia@me.com>
@lelia lelia requested a review from a team as a code owner August 30, 2024 00:27
@lelia lelia requested review from justaugustus and spencerschrock and removed request for a team August 30, 2024 00:27
Signed-off-by: lelia <le1ia@me.com>
Signed-off-by: lelia <le1ia@me.com>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the JSON source and sending the PR! Small comment.

checks/raw/license.go Outdated Show resolved Hide resolved
Signed-off-by: lelia <le1ia@me.com>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@spencerschrock spencerschrock merged commit 4e9b1a0 into ossf:main Sep 10, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

update the SPDX license list
2 participants