-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Update SPDX license list, source for license data #4323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lelia <le1ia@me.com>
lelia
requested review from
justaugustus and
spencerschrock
and removed request for
a team
August 30, 2024 00:27
Signed-off-by: lelia <le1ia@me.com>
Signed-off-by: lelia <le1ia@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding the JSON source and sending the PR! Small comment.
lelia
temporarily deployed
to
integration-test
September 3, 2024 20:31
— with
GitHub Actions
Inactive
Signed-off-by: lelia <le1ia@me.com>
lelia
temporarily deployed
to
integration-test
September 5, 2024 15:46
— with
GitHub Actions
Inactive
spencerschrock
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updates the existing SPDX license list to include the latest data from SPDX.
Updates comment to point to new data source for the license list. The SPDX have recently made a GitHub repository available containing a JSON formatted license list for easier programmatic consumption.
PR title follows the guidelines defined in our pull request documentation
What is the current behavior?
The outdated list of licenses causes some users to experience lower scores on License checks, in addition including licenses that are not FSF/OSI-approved.
What is the new behavior (if this is a feature change)?**
The updated list of licenses should help prevent these issues.
Which issue(s) this PR fixes
Fixes #4031
Special notes for your reviewer
For now, this just updates the list of licenses. A future enhancement can be added to programmatically fetch the licenses from the SPDX repo, and format the data in the way that
fsfOsiApprovedLicenseMap
expects.Does this PR introduce a user-facing change?