🐛 Replace errors.As with Is
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeemshaikh38
force-pushed
the
azeems/errors
branch
from
ceb17bd
to
9265201
Compare
|
Integration tests success for ceb17bd239340a4b8574ff4e300f17f445feaffa |
|
Integration tests success for 9265201bcd2454ccc3fede368a26deb6adf8f9e1 |
azeemshaikh38
force-pushed
the
azeems/errors
branch
from
9265201
to
31a3284
Compare
|
Integration tests success for 31a3284b9c054ea1628dcc5538c22362ceb81d4f |
azeemshaikh38
force-pushed
the
azeems/errors
branch
from
31a3284
to
43552f0
Compare
azeemshaikh38
force-pushed
the
azeems/errors
branch
from
43552f0
to
34622e1
Compare
|
Integration tests success for 43552f04309f50ebfe5b313b3920c026d891e75d |
|
Integration tests success for 34622e1e8915d8327281f467e1d59229fb4144b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Replace
errors.Ascalls withIsto avoid overwriting original error values. Thanks to @laurentsimon 🐛 Fixes for Branch Protection #900 (comment)Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.