Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update test utils #933

Merged
merged 1 commit into from
Aug 30, 2021
Merged

🌱 Update test utils #933

merged 1 commit into from
Aug 30, 2021

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Use cmp package for result comparison
  • Update Errors to Error
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@github-actions
Copy link

Integration tests success for 06a853153ef85b2309fbe40137a86991c5cc4ad6

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) August 30, 2021 19:48
@github-actions
Copy link

Integration tests success for fa71596f1c86feab22bd5c08ceb4bfc9ddf121b9

laurentsimon
laurentsimon approved these changes Aug 30, 2021
View reviewed changes
checks/branch_protection_test.go
@@ -348,7 +348,7 @@ func TestReleaseAndDevBranchProtected(t *testing.T) {
{
name: "TargetCommittish nil",
expected: scut.TestReturn{
Errors: []error{sce.ErrScorecardInternal},
Error: sce.ErrScorecardInternal,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: the list of errors was intentional: any time we have a wrapped error we expose (currently none :-)), we could check it using the list.

@azeemshaikh38 azeemshaikh38 merged commit d9f5209 into main Aug 30, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/utests branch August 30, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@oliverchang oliverchang Awaiting requested review from oliverchang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azeemshaikh38 @laurentsimon @azeemsgoogle