-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Improve JSON format #934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we decouple logic for cron job JSON from Scorecard JSON before this PR?
I'll start working on it. Are there unit tests needs for the cron job/JSON? I don't see any. I think I'll add JSON unit tests/schema validator as I did for the scorecard JSON format. Sounds good? |
SGTM |
888fd07
to
feded4c
Compare
done with #941 |
feded4c
to
d4db686
Compare
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
lack of info in JSON format
What is the new behavior (if this is a feature change)?
pkg/
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: