AO3-5728 Allow flexbox in skins #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just adds them to the list; a future commit will update the line lengths
It's not a security risk, but 'align' by itself is not a valid property, so having it in the shorthand list doesn't make sense despite being easier.
* More double quotes * Less should
brianjaustin
approved these changes
Jun 16, 2023
| context 'no user argument given' do | ||
| context 'User.current_user is nil' do | ||
| it 'returns approved skins' do | ||
| context "no user argument given" do |
|
I'm nosing around for other reasons, but is there supposed to be a comma after Pause on l. 357 of the config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-5728
Purpose
Allows flexbox in skins.
Testing Instructions
Refer to Jira.
Credit
Sarken, she/her