Bugfix: [Relay Pagination] Fixed query limit if no 'first' parameter set #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for bringing this up @sharif9876! @alafon can you review this please? |
|
If you type hint the |
|
@adri I'm not using this part of the bundle so if you much more accustomed with this can you provide some example please? If needed we can patch this in current stable version. |
|
@mcg-web No need to patch I think, just wanted to mention this for future reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with Relay pagination, if you don't include a
firstparameter in your query, your response will be limited to 1 result.This is because the logic was, for instance:
$limit + 1, so even if$limitwasnull, we'd still end up limiting to 1.