Skip to content

Bugfix: [Relay Pagination] Fixed query limit if no 'first' parameter set #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Bugfix: [Relay Pagination] Fixed query limit if no 'first' parameter set #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Relay/Connection/Paginator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ public function forward($args)

// If we don't have a cursor or if it's not valid, then we must not use the slice method
if (!is_numeric(ConnectionBuilder::cursorToOffset($args['after'])) || !$args['after']) {
$entities = call_user_func($this->fetcher, $offset, $limit + 1);
$entities = call_user_func($this->fetcher, $offset, $limit ? $limit + 1 : $limit);

return $this->handleEntities($entities, function ($entities) use ($args) {
return ConnectionBuilder::connectionFromArray($entities, $args);
});
} else {
$entities = call_user_func($this->fetcher, $offset, $limit + 2);
$entities = call_user_func($this->fetcher, $offset, $limit ? $limit + 2 : $limit);

return $this->handleEntities($entities, function ($entities) use ($args, $offset) {
return ConnectionBuilder::connectionFromArraySlice($entities, $args, [
Expand Down