fix(api): notification as code duplicates (#5194)

Author: fsamin

engine/api/workflow/dao_node_run.go

@@ -607,7 +607,7 @@ func GetNodeRunBuildCommits(ctx context.Context, db gorp.SqlExecutor, store cach
 		}
 		if br != nil {
 			if br.LatestCommit == "" {
-				return nil, cur, sdk.WrapError(sdk.ErrNoBranch, "branch %s or latest commit not found", cur.Branch)
+				return nil, cur, sdk.WrapError(sdk.ErrNoBranch, "branch %s latest commit not found", cur.Branch)
 			}
 
 			//and return the last commit of the branch

engine/api/workflow/execute_node_run.go

@@ -1038,7 +1038,7 @@ func getVCSInfos(ctx context.Context, db gorp.SqlExecutor, store cache.Store, pr
 	if err != nil {
 		log.Error(ctx, "cannot get from cache %s: %v", cacheKey, err)
 	}
-	if find {
+	if find && vcsInfos.Branch != "" && vcsInfos.Hash != "" {
 		log.Debug("completeVCSInfos> load from cache: %s", cacheKey)
 		return &vcsInfos, nil
 	}