fix(ui): fix websocket workflow run filter (#5161)

Author: sguiheux

engine/api/websocket.go

@@ -372,13 +372,16 @@ func (c *websocketClient) send(ctx context.Context, event sdk.Event) (err error)
 	case strings.HasPrefix(event.EventType, "sdk.EventRunWorkflow") && c.filter.Type == sdk.WebsocketFilterTypeWorkflow:
 		if event.ProjectKey != c.filter.ProjectKey || event.WorkflowName != c.filter.WorkflowName {
 			sendEvent = false
+			break
 		}
 		if c.filter.WorkflowRunNumber != 0 && event.WorkflowRunNum != c.filter.WorkflowRunNumber {
 			sendEvent = false
+			break
 		}
 		// WORKFLOW NODE RUN EVENT
 		if c.filter.WorkflowNodeRunID != 0 && event.WorkflowNodeRunID != c.filter.WorkflowNodeRunID {
 			sendEvent = false
+			break
 		}
 		sendEvent = true
 	default:

engine/api/websocket_test.go

@@ -166,19 +166,23 @@ func Test_websocketGetWorkflowEvent(t *testing.T) {
 	go client.WebsocketEventsListen(context.TODO(), chanMessageToSend, chanMessageReceived)
 
 	chanMessageToSend <- sdk.WebsocketFilter{
-		Type:         sdk.WebsocketFilterTypeWorkflow,
-		ProjectKey:   key,
-		WorkflowName: w.Name,
+		Type:              sdk.WebsocketFilterTypeWorkflow,
+		ProjectKey:        key,
+		WorkflowName:      w.Name,
+		WorkflowRunNumber: 1,
 	}
 	// Waiting websocket to update filter
 	time.Sleep(1 * time.Second)
 
-	api.websocketBroker.messages <- sdk.Event{ProjectKey: proj.Key, WorkflowName: w.Name, EventType: "sdk.EventWorkflow"}
+	api.websocketBroker.messages <- sdk.Event{ProjectKey: "blabla", WorkflowName: "toto", EventType: "sdk.EventRunWorkflow", WorkflowRunNum: 1}
+	api.websocketBroker.messages <- sdk.Event{ProjectKey: proj.Key, WorkflowName: w.Name, EventType: "sdk.EventRunWorkflow", WorkflowRunNum: 1}
 	response := <-chanMessageReceived
 	require.Equal(t, "OK", response.Status)
-	require.Equal(t, response.Event.EventType, "sdk.EventWorkflow")
+	require.Equal(t, response.Event.EventType, "sdk.EventRunWorkflow")
 	require.Equal(t, response.Event.ProjectKey, proj.Key)
 	require.Equal(t, response.Event.WorkflowName, w.Name)
+
+	assert.Equal(t, 0, len(chanMessageReceived))
 }
 
 func Test_websocketDeconnection(t *testing.T) {