Fix expansion of selective sync tree #10058
Conversation
fmoc
force-pushed
the
work/fix-selective-sync
branch
from
672dc9a
to
407ff60
Compare
fmoc
force-pushed
the
work/fix-selective-sync
branch
from
407ff60
to
660fdf6
Compare
|
We decided to have another look. |
|
I had another look and I think this new fix is significantly better than my last attempt. Now there is a check to make sure invalid |
Might be the better solution overall
fmoc
force-pushed
the
work/fix-selective-sync
branch
from
355129a
to
6a698f2
Compare
|
The flag used to be used to query whether the root folder is ready. I just forgot to implement that same functionality for subfolders as well. It has got its use. I updated the patch to perform the check properly for subfolders as well, i.e., it's actually doing something useful now. I think we actually have to review the return values of |
|
Currently, whenever you use That removes alternative code pathes that actually do the same thing. |
|
Makes sense, totally agree, thanks! |
|
Kudos, SonarCloud Quality Gate passed! |
This commit restores the use of FolderStatusDelegate::data(...) to check whether a folder is ready. The two additions fix two different ways in which the client could crash. Using data(...) makes sure we use the right data structure to look up the ready state for the subfolders. Using folder(...) rightfully causes an index out of range error. This commit partially reverts #10058 and restores a previous version of said PR.
This commit restores the use of FolderStatusDelegate::data(...) to check whether a folder is ready. The two additions fix two different ways in which the client could crash. Using data(...) makes sure we use the right data structure to look up the ready state for the subfolders. Using folder(...) rightfully causes an index out of range error. This commit partially reverts #10058 and restores a previous version of said PR.
_is_blacklisted.png){kind=link}
_are_copied_over_to_the_server.png){kind=link}
Before:
After:
