Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: Display docker icon when settings are visible #7868

Merged
merged 1 commit into from
May 15, 2020
Merged

Mac: Display docker icon when settings are visible #7868

merged 1 commit into from
May 15, 2020

Conversation

TheOneRing
Copy link
Member

No description provided.

@TheOneRing TheOneRing changed the title Mac Mac: Display docker icon when settings are visible May 15, 2020
@TheOneRing TheOneRing merged commit 6ea9cb5 into owncloud:master May 15, 2020
@TheOneRing TheOneRing deleted the mac branch May 15, 2020 11:15
@guruz
Copy link
Contributor

guruz commented May 15, 2020

Nice!
I wanted to do this for a long time, but never did it :-)
Only downside I see is that people might not understand that there is a menu bar icon. (they probably didnt understand before either..)
I solved this in ocsmount by force-showing the menu after the configuration dialog is closed.

misch7 pushed a commit to nextcloud/desktop that referenced this pull request Jul 4, 2020
@TheOneRing @misch7
Mac: Display dock icon when settings are visible
607045b 
Adopt upstream commit c5678f3 (owncloud/client#7868)

Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7 pushed a commit to nextcloud/desktop that referenced this pull request Jul 6, 2020
@TheOneRing @misch7
Mac: Display dock icon when settings are visible
268c049 
Adopt upstream commit c5678f3 (owncloud/client#7868)

Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7 pushed a commit to nextcloud/desktop that referenced this pull request Jul 14, 2020
@TheOneRing @misch7
Mac: Display dock icon when settings are visible
4a4d7d8 
Adopt upstream commit c5678f3 (owncloud/client#7868)

Signed-off-by: Michael Schuster <michael@schuster.ms>
@jnweiger jnweiger mentioned this pull request Oct 13, 2020
Closed
63 tasks
@jnweiger
Copy link
Contributor

Crude screenshots:
First with the settings window open, second with the settings window closed:

20201021_110915
20201021_110535

In both cases, we have a small icon in the top icon bar, and a large owncloud icon in the bottom dock panel.

@jnweiger
Copy link
Contributor

@TheOneRing @michaelstingl should the big owncloud icon in the dock disappear, when we close the settings window? On Linux it disappears.

@TheOneRing
Copy link
Member Author

It will disappear, but the dock displays the last few used applications when not more than n windows are open.

@jnweiger
Copy link
Contributor

That is more userfriendly than expected. OK.

@jnweiger jnweiger mentioned this pull request Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneuwert mneuwert mneuwert approved these changes

@ogoffart ogoffart Awaiting requested review from ogoffart

@dschmidt dschmidt Awaiting requested review from dschmidt

@michaelstingl michaelstingl Awaiting requested review from michaelstingl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheOneRing @guruz @jnweiger @mneuwert