Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobQueue #8293

Merged
merged 8 commits into from
Jan 13, 2021
Merged

JobQueue #8293

merged 8 commits into from
Jan 13, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

TheOneRing
TheOneRing commented Dec 10, 2020
View reviewed changes
src/libsync/jobqueue.h Outdated Show resolved Hide resolved
TheOneRing
TheOneRing commented Dec 10, 2020
View reviewed changes
src/libsync/jobqueue.h Outdated Show resolved Hide resolved
@TheOneRing TheOneRing force-pushed the work/jobqueue branch 2 times, most recently from a5defc3 to ac3329a Compare December 15, 2020 11:19
@TheOneRing TheOneRing changed the title [WIP] rework queue JobQueue Dec 15, 2020
@TheOneRing TheOneRing marked this pull request as ready for review December 15, 2020 11:20
@TheOneRing TheOneRing changed the title JobQueue [WIP]JobQueue Dec 15, 2020
@TheOneRing

This comment has been minimized.

Sign in to view
@TheOneRing TheOneRing changed the title [WIP]JobQueue JobQueue Dec 16, 2020
dragotin
dragotin approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment I made (which is minor) I can not see anything suspicious.

Very good work. Makes the code more clear and solves problems 🥇

However, this is a significant change that needs good testing.

src/libsync/jobqueue.cpp Outdated
}

bool JobQueue::needsRetry(AbstractNetworkJob *job) const
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why this method is in JobQueue and not in the Job class directly. The job should be the source if retry is needed or not.

And the implementation indeed only uses job data to find out. So this method could be moved to Job::needsRetry()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point thx

@TheOneRing TheOneRing merged commit c51d569 into master Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/jobqueue branch January 13, 2021 09:13
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger mentioned this pull request Aug 23, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragotin dragotin dragotin approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheOneRing @dragotin