dynamic oidc registration #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/oidc_dynamic
branch
3 times, most recently
from
d853a0e
to
6c0a397
Compare
TheOneRing
requested review from
DeepDiver1975,
dragotin,
dschmidt and
felix-schwarz
TheOneRing
force-pushed
the
work/oidc_dynamic
branch
from
6c0a397
to
4d150d8
Compare
felix-schwarz
approved these changes
Jan 13, 2021
| @@ -35,6 +36,11 @@ void AbstractCredentials::setAccount(Account *account) | |||
| _account = account; | |||
| } | |||
|
|
|||
| QString AbstractCredentials::keychainServerWhideKey(Account *acc, const QString &key) | |||
There was a problem hiding this comment.
Little typo here: …WhideKey vs …WideKey.
There was a problem hiding this comment.
Last night I also thought about the fact that we can clash here if two accounts start the process at the same time...
Which is a reason against ServerWide keys, but during registration I don't know the username yet, if I use a uuid assigned to the account, I would need cleanup during account removal and.....
TheOneRing
force-pushed
the
work/oidc_dynamic
branch
from
4d150d8
to
7f45934
Compare
|
Kudos, SonarCloud Quality Gate passed! |
12 tasks
12 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.