Clicking in the middle of the row in the file list downloads the file instead of showing the details

[jvillafanez]

Steps to reproduce

Checked with latest master code

1. Upload any file
2. Click in the empty space between the filename and the share icon

Expected behaviour

Right panel should show up showing the detail of the files (activity, comments, sharing, etc)

Actual behaviour

Download is triggered. This is a change in the behavior

Server configuration

Operating system: ubuntu 20.04

Web server: apache 2.4

Database: mysql

PHP version: 7.3

ownCloud version: master branch (commit 7a54753)

Updated from an older ownCloud or fresh install: fresh install

Where did you install ownCloud from:

Signing status (ownCloud 9.0 and above):

Login as admin user into your ownCloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results into https://gist.github.com/ and puth the link here.

The content of config/config.php:

Log in to the web-UI with an administrator account and click on
'admin' -> 'Generate Config Report' -> 'Download ownCloud config report'
This report includes the config.php settings, the list of activated apps
and other details in a well sanitized form.

or 

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your ownCloud installation folder

*ATTENTION:* Do not post your config.php file in public as is. Please use one of the above
methods whenever possible. Both, the generated reports from the web-ui and from occ config:list
consistently remove sensitive data. You still may want to review the report before sending.
If done manually then it is critical for your own privacy to dilligently
remove *all* host names, passwords, usernames, salts and other credentials before posting.
You should assume that attackers find such information and will use them against your systems.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your ownCloud installation folder.

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption: yes/no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

LDAP configuration (delete this part if not used)

With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your ownCloud installation folder

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap';


Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

Client configuration

Browser:

Operating system:

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

Insert your ownCloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...

I'm not sure if this has been discussed, but we might re-evaluate the user experience around this.

[JammingBen]

@janackermann ^

[AlexAndBear]

Yes can confirm, this seems to be introduced with 10.8 or ?
So I would vote for not a regression.

@jvillafanez if you come up with a fix, it is important to double check the behaviour on small screens e.G smartphones

[JammingBen]

10.7 introduced it I believe. But still a regression, isn't it? Meaning something we messed up but did not intend to do.

[AlexAndBear]

@JammingBen yes of course it is a 'regession' but I guess there is a difference how BTR for example decide if it is a regression or a bug,

Was there before the last release: bug
Has been introduced just yet: regression

Anyways, not that important =)

[phil-davis]

I remember some discussion about this - but how to find it. It might have been purposely changed (or at least purposely accepted when the change happened for other reasons). From memory, people thought that the previous behavior was a bit "odd". If the file/folder had a very short name, then the user had only had a small width to click in to open (or download) the resource. If the name was long then there was lots of width to click in.

With the current/new behavior, the user can move their mouse vertically down the middle of the file list and click on a file/folder and get the same behavior regardless of the length of the file name. That seems a better UI to me.

To open the sharing panel, the user always has to click over to the right on the sharing icon.

[jvillafanez]

The drawbacks I see are:

• The previous behavior has been there from a long time. Changing the behavior will be disruptive for people who has been using ownCloud for a while.
• Some browsers (Chrome in particular, maybe others) can download the file directly without asking for confirmation (I don't think people usually change these settings). This might be problematic if the browser starts downloading instead of showing the details. I wouldn't count on the user to be smart to cancel the download right away.
• There is no visual indicator where to click or not to click in order to download the file (just the mouse icon). The current behavior seems to suggest that clicking anywhere in the row (except in the icons) will download the file. However, clicking to the right of the sharing icon will show the details instead of downloading the file; this seems inconsistent with the idea of clicking in the row to download the file because text is usually considered part of some content (in this case the row), not content itself.

If this has been discussed and I'm the only one complaining, you can close the ticket. If the change it already out (I didn't notice 😮 ) reverting the behavior will be more annoying.

@jvillafanez if you come up with a fix, it is important to double check the behaviour on small screens e.G smartphones

Leaving a related image here. I'll open a different ticket for this.

It looks difficult to open the details panel in this case. You must click on the 3 points menu, which I don't think it's common.

[AlexAndBear]

@jvillafanez I don't like the current behavior as well, I think this has been introduced by accident (some UI improvements for mobile), where the nametext span width has been set to a much higher value

[jvillafanez]

Linking with #39330 for the issues with small screens

[jvillafanez]

I've checked that 10.8 has this behavior. 10.7 (checked through the univention appliance) have the old one.

I think we need to clarify whether the change was intentional or not. Taking into account that the change is out there, reverting it might be problematic

[JammingBen]

@pmaier1 Any feelings regarding this? How should a click on a row behave: open the sidebar as it was before 10.8 or trigger the default action as it is currently?

[pmaier1]

@pmaier1 Any feelings regarding this? How should a click on a row behave: open the sidebar as it was before 10.8 or trigger the default action as it is currently?

Open the sidebar, please.

[AlexAndBear]

As I mentioned before, this issue has been brought in due to multiple tries, make it more mobile-user friendly.
Generally, clicking on the class nametext triggers a download, elsewhere it opens the right sidebar menu.
This should be fixed

v10.6

master