Move core apps from private to public functions (trivial part) #15356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps still use OC_Helper and OC_Util functions even when public ones are already available. Sometimes the public one is even used in the same file.
|
👍 |
|
The inspection completed: No new issues |
|
awesome 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
rullzer
pushed a commit
that referenced
this pull request
Apr 1, 2015
Move core apps from private to public functions (trivial part)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4774
This commit just moves the apps to already available public functions in \OCP\Util. Sometimes even some calls in the apps were to the OCP ones while other still were to the OC_ ones.
Anyway, trivial fix.
CC: @DeepDiver1975 @butonic @LukasReschke @MorrisJobke