Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from private static function OC_Util::getUrlContent #15470

Merged
merged 2 commits into from
Jul 3, 2015
Merged

Move away from private static function OC_Util::getUrlContent #15470

merged 2 commits into from
Jul 3, 2015

Conversation

rullzer
Copy link
Contributor

@rullzer rullzer commented Apr 8, 2015

As described in #4774

  • This moves the files_sharing app away from OC_Util::getUrlContent.
  • Deprecates OC_Util::getUrlContent, it is just a wrapper around a deprecated function. So it should go.

@rullzer rullzer added this to the 8.2-next milestone Apr 8, 2015
@rullzer rullzer mentioned this pull request Apr 8, 2015
Closed
@karlitschek
Copy link
Contributor

looks good. What do you think @schiesbn

@nickvergessen
Copy link
Contributor

Diff without whitespaces looks good:
https://github.com/owncloud/core/pull/15470/files?w=1

@rullzer
Copy link
Contributor Author

rullzer commented Apr 15, 2015

@nickvergessen nice, did not know about that function!
With whitespace is indeed some reindentation because the structure is slightly different. But the code is unchanged indeed :)

@rullzer
Move away from private static deprecated functio
be8d0a0
@rullzer
Depreatace OC_Util::getUrlContent
9866066 
It is just a wrapper and the other functions are deprecated already
@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link

ghost commented May 18, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/12377/
🚀 Test PASSed.🚀
chuck

@th3fallen
Copy link
Contributor

👍

MorrisJobke
MorrisJobke reviewed Jul 2, 2015
View reviewed changes
lib/private/util.php
@@ -1234,6 +1234,7 @@ public static function generateRandomBytes($length = 30) {
* @return string of the response or false on error
* This function get the content of a page via curl, if curl is enabled.
* If not, file_get_contents is used.
* @deprecated Use \OCP\Http\Client\IClientService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already deprecated, but the message above needs an update.

@PVince81
Copy link
Contributor

PVince81 commented Jul 3, 2015

Tested, works 👍

PVince81 pushed a commit that referenced this pull request Jul 3, 2015
Merge pull request #15470 from rullzer/files_sharing_getUrlContent
cc373ab 
Move away from private static function OC_Util::getUrlContent
@PVince81 PVince81 merged commit cc373ab into owncloud:master Jul 3, 2015
@rullzer rullzer deleted the files_sharing_getUrlContent branch July 4, 2015 05:00
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review app:files_external enhancement
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
7 participants
@rullzer @karlitschek @nickvergessen @scrutinizer-notifier @th3fallen @PVince81 @MorrisJobke