Skip to content

Fix namespace XML output of files and tags dav #20931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Fix namespace XML output of files and tags dav #20931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dav/lib/connector/sabre/filesplugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function __construct(\Sabre\DAV\Tree $tree,
*/
public function initialize(\Sabre\DAV\Server $server) {

$server->xmlNamespaces[self::NS_OWNCLOUD] = 'oc';
$server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
$server->protectedProperties[] = self::FILEID_PROPERTYNAME;
$server->protectedProperties[] = self::INTERNAL_FILEID_PROPERTYNAME;
$server->protectedProperties[] = self::PERMISSIONS_PROPERTYNAME;
Expand Down
2 changes: 1 addition & 1 deletion apps/dav/lib/connector/sabre/tagsplugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function __construct(\Sabre\DAV\Tree $tree, \OCP\ITagManager $tagManager)
*/
public function initialize(\Sabre\DAV\Server $server) {

$server->xmlNamespaces[self::NS_OWNCLOUD] = 'oc';
$server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
Copy link
Contributor

@phil-davis phil-davis Aug 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as a typo, it should be
namespaceMap
See PR #40943 for the fix.

CI passed at the time, so I suppose there was no unit test that effectively tested this.

$server->propertyMap[self::TAGS_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\TagList';

$this->server = $server;
Expand Down