Skip to content

Conversation

phil-davis
Copy link
Contributor

Description

Fixup use of Gherkin "When" and "Then" in various places in the UI tests

Related Issue

Motivation and Context

After looking at PR #29521 I realised that a few feature files were missing "When" keywords in the appropriate places.

How Has This Been Tested?

Travis knows

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor Author

Backport stable10 #29523

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #29522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29522   +/-   ##
=========================================
  Coverage     61.37%   61.37%           
  Complexity    17436    17436           
=========================================
  Files          1042     1042           
  Lines         57630    57630           
=========================================
  Hits          35368    35368           
  Misses        22262    22262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a822189...c399311. Read the comment docs.

@phil-davis phil-davis merged commit 3d6b92f into master Nov 10, 2017
@phil-davis phil-davis deleted the ui-tests-share-by-link-gherkin branch November 10, 2017 00:36
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants