Refactor UI tests user creation #29584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
approved these changes
Nov 15, 2017
phil-davis
force-pushed
the
ui-tests-user-creation
branch
from
92ebc8e to
cb0fd48
Compare
Codecov Report
@@ Coverage Diff @@
## master #29584 +/- ##
=========================================
Coverage 61.78% 61.78%
Complexity 17482 17482
=========================================
Files 1047 1047
Lines 57714 57714
=========================================
Hits 35657 35657
Misses 22057 22057Continue to review full report at Codecov.
|
|
Backport stable10 #29586 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating users, download a little file for the user - that triggers the user account initialization (e.g. creating the skeleton files). In special cases (like when really testing first-time webUI login) then override this.
Related Issue
Motivation and Context
Some UI tests have steps that login and logout each newly-created user via the webUI just so that they get their skeleton files etc. set up. This is a waste of browser steps, it could be faster to do the skeleton file setup another way and also avoid having these odd-looking steps in the Behat-Gherkin.
How Has This Been Tested?
Travis
Types of changes
Checklist: