Reset FilesContext on logout #29611
Merged
Reset FilesContext on logout #29611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
approved these changes
Nov 17, 2017
|
Backport stable10 #29614 |
Codecov Report
@@ Coverage Diff @@
## master #29611 +/- ##
=========================================
Coverage 61.82% 61.82%
Complexity 17501 17501
=========================================
Files 1045 1045
Lines 57712 57712
=========================================
Hits 35683 35683
Misses 22029 22029Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a test step logs out, notify FilesContext so that it can reset anything that it has been remembering about where it is or what has been done on the files page.
Related Issue
Motivation and Context
If I write UI test steps that navigate into
folderaas user1, check some stuff, then logout and login as user1 and navigate intofolderband check some stuff, then FilesContext keeps appending the folders that I have navigated into.That makes FilesContext think that the test is now in
foldera/folderb- which causes issues for any test steps that try to download a file from the "current folder".How Has This Been Tested?
UI tests run locally, including with future test steps for sharing with groups (that is how I discovered this bug)
Types of changes
Bug fix to UI test infrastructure only - no bug in end-user code.
Checklist: