Skip to content

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 3, 2021

Description

  1. Update PHP dependencies:
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading doctrine/dbal (2.13.3 => 2.13.4)
  - Upgrading phpdocumentor/type-resolver (1.5.0 => 1.5.1)
  - Upgrading roave/security-advisories (dev-master 4911abe => dev-master 0488e16)
Writing lock file

https://github.com/doctrine/dbal/releases/tag/2.13.4

Note: phpdocumentor/type-resolver is a dev dependency, so does not need to be in the changelog.

  1. Fix the CI fail processing the JavaScript test coverage report folder name. It has the Firefox version number in it, which has increased from 91 to 92. This is a bit of a pain! I will fix it ffor now, but I guess that we should work out a way to automagically know/process this in future.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added dependencies php Pull requests that update Php code labels Oct 3, 2021
@phil-davis phil-davis self-assigned this Oct 3, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phil-davis phil-davis merged commit 12074e4 into master Oct 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the dbal-2.13.4 branch October 3, 2021 13:19
@phil-davis phil-davis mentioned this pull request Oct 3, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants