This repository was archived by the owner on Oct 31, 2018. It is now read-only.
Throw login exception in preLogin instead of sleep #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakayasemi
changed the title
Contributor
|
Some styling on the input fields is missing |
phil-davis
reviewed
Aug 21, 2017
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Some suggestions for wording of text strings.
js/settings-admin.js
Outdated
| OC.AppConfig.setValue('security', 'brute_force_protection_ban_period', banPeriod); | ||
| OC.msg.finishedSuccess('#security-save-bfp-settings-message', OC.L10N.translate('Security', 'Preferences are saved')); | ||
| } else { | ||
| OC.msg.finishedError('#security-save-bfp-settings-message', OC.L10N.translate('Security', 'Inputs are should be positive integer')); |
lib/SecurityConfig.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Look failed login attempts in how many seconds? |
There was a problem hiding this comment.
Count failed login attempts over how many seconds
lib/SecurityConfig.php
Outdated
| } | ||
|
|
||
| /** | ||
| * How many seconds ban attacker |
There was a problem hiding this comment.
How many seconds to ban an attacker
templates/settings-admin.php
Outdated
| <h2 class="inlineblock"><?php p($l->t('Brute Force Protection')); ?></h2> | ||
| <span id="security-save-bfp-settings-message" class="msg"></span> | ||
| <div> | ||
| <label for="security-bfp-threshold-time"><?php p($l->t('Look failed login attempts in how many seconds?')) ?></label><br> |
There was a problem hiding this comment.
Count failed login attempts over how many seconds?
DeepDiver1975
suggested changes
Aug 21, 2017
js/settings-admin.js
Outdated
| OC.AppConfig.setValue('security', 'brute_force_protection_time_threshold', thresholdTime); | ||
| OC.AppConfig.setValue('security', 'brute_force_protection_fail_tolerance', failTolerance); | ||
| OC.AppConfig.setValue('security', 'brute_force_protection_ban_period', banPeriod); | ||
| OC.msg.finishedSuccess('#security-save-bfp-settings-message', OC.L10N.translate('Security', 'Preferences are saved')); |
Contributor
There was a problem hiding this comment.
please use t() instead of OC.L10N.translate - only using t() the extraction tool can extract strings - THX
tests/Db/DbServiceTest.php
Outdated
| $this->connection = \OC::$server->getDatabaseConnection(); | ||
| $this->factory = new TimeFactory(); | ||
| $this->dbService = new DbService($this->connection, $this->factory); | ||
| $this->configMock = $this->getMockBuilder('OCA\Security\SecurityConfig') |
Contributor
There was a problem hiding this comment.
Just comment for the future use:
SecurityConfig::class
tests/HooksTest.php
Outdated
|
|
||
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
| $this->dispatcherMock = $this->getMockBuilder('Symfony\Component\EventDispatcher\EventDispatcher') |
karakayasemi
force-pushed
the
doesNotUseSleep
branch
3 times, most recently
from
bd6335f to
c25fcbd
Compare
Contributor
|
Please use rebase instead of merge
|
karakayasemi
force-pushed
the
doesNotUseSleep
branch
4 times, most recently
from
0c43986 to
c84016a
Compare
karakayasemi
force-pushed
the
doesNotUseSleep
branch
from
c84016a to
20b85ce
Compare
Contributor
Author
|
@DeepDiver1975 any obstacle? |
DeepDiver1975
approved these changes
Aug 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brute force settings now configurable.
Sleep is removed, #12
Ip will be blocked after too many failed attempts #11
admin settings style is enhanced #7
Indentation mistakes are fixed #18