This repository was archived by the owner on Oct 31, 2018. It is now read-only.
set max version 10.0.8 and add deprecation info #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 71.76% 71.76%
Complexity 73 73
=========================================
Files 12 12
Lines 301 301
=========================================
Hits 216 216
Misses 85 85
Continue to review full report at Codecov.
|
PVince81
reviewed
Jul 15, 2018
templates/settings-admin.php
Outdated
| ?> | ||
| <div id="security-brute-force-protection" class="section"> | ||
| <h2 class="inlineblock"><?php p($l->t('Brute Force Protection')); ?></h2> | ||
| <h3 class="warning"><?php p($l->t('This app will be deprecated and will not be further version. You can use the Password Policy app and the Brute Force Protection app to achieve the same functionality.')); ?></h3> |
Contributor
There was a problem hiding this comment.
"and will not" => "and there will not"
karakayasemi
force-pushed
the
final-release
branch
from
68b47da to
e2a87b1
Compare
Contributor
Author
|
@PVince81 ready to review again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #35, it is the final release. Max version set as 10.0.8. Deprecation message added to info.xml and admin-settings.