Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retrieve audio and location metadata #10125

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Dec 6, 2023

Description

Load audio and location metadata in propfinds.

Related Issue

Motivation and Context

I want to make metadata available to extensions, especially sidebar panels (c.f. #10111)
MS Graph API returns audio and location facets as soon as they are available for a driveItem - assuming oCIS wants to stay compatible with that and that we are going to switch to graph api at some point, I think we don't need to add complexity for loading these props only on demand.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Dec 6, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dschmidt dschmidt merged commit 83d5247 into master Dec 6, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/audio-and-location-metadata branch December 6, 2023 17:35
ownclouders pushed a commit that referenced this pull request Dec 6, 2023
…tadata

feat: retrieve audio and location metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants