Exif and audio panels #10956
Exif and audio panels #10956
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
exif-panel
branch
2 times, most recently
from
0a20175
to
f2d81fa
Compare
|
Would love to change "Musical genre" to "Genre". Sounds a little too lofty. |
I was getting inspiration from the field labels in mac finder file info. :-) But also fine with |
packages/web-app-files/src/components/SideBar/Audio/AudioMetaPanel.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Audio/AudioMetaPanel.vue
Outdated
Show resolved
Hide resolved
kulmann
force-pushed
the
exif-panel
branch
2 times, most recently
from
091eaa1
to
747ee01
Compare
kulmann
force-pushed
the
exif-panel
branch
2 times, most recently
from
4b1ec54
to
2d66bfd
Compare
| @@ -67,6 +69,7 @@ export default defineComponent({ | |||
| return '-' | |||
| } | |||
| if ([5, 6, 7, 8].includes(unref(resource).photo?.orientation)) { | |||
| // these orientations indicate portrait mode. tika normalizes width and height according to orientation. | |||
There was a problem hiding this comment.
What a weird thing to do, should we maybe handle this on server side instead?
There was a problem hiding this comment.
please not for this PR 🙈 maybe as a followup 😅
packages/web-app-files/tests/unit/components/SideBar/Exif/ExifPanel.spec.ts
Outdated
Show resolved
Hide resolved
| if (!data) { | ||
| return data | ||
| } | ||
| const converted = {} |
There was a problem hiding this comment.
Should be typed, otherwise the return of the method is not properly typed.
There was a problem hiding this comment.
I don't have a better type than Record<string, any> here 🙈
packages/web-app-files/src/components/SideBar/Audio/AudioMetaPanel.vue
Outdated
Show resolved
Hide resolved
…anel.vue Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
|
| <dt v-text="$gettext('Dimensions')" /> | ||
| <dd data-testid="exif-panel-dimensions" v-text="dimensions" /> | ||
| <dt v-text="$gettext('Device make')" /> | ||
| <dd data-testid="exif-panel-cameraMake" v-text="cameraMake" /> |
There was a problem hiding this comment.
Why do we have the mix aus Kebap and camelCase here? 😅
There was a problem hiding this comment.
Because it's only data-testids? 🙈 Normally we use kebab case in html. I'm using them in a generic way and just inline the object keys. The object keys are camelCase. If you're super unhappy with that I can transform the object keys to kebab case first. 🤷
There was a problem hiding this comment.
fine for me, is wa just confused
* feat: exif panel for image and photo metadata and audio panel
|
🎉 🎉 🎉 I love it so so much! Thanks! Now ... multiple root panels? ;-) |
Description
This PR introduces an
EXIFpanel, which displays image, photo and location metadata if that's available on the given resource as well as anAudio Infopanel, which displays audio metadata if that's available on the given resource.Related Issue
Motivation and Context
Provide useful additional information.
Screenshots
Types of changes
Open tasks: